Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Remove scala KafkaException #11913

Merged
merged 1 commit into from
Mar 21, 2022
Merged

MINOR: Remove scala KafkaException #11913

merged 1 commit into from
Mar 21, 2022

Conversation

dengziming
Copy link
Member

More detailed description of your change
We use org.apache.kafka.common.KafkaException instead of kafka.common.KafkaException

Summary of testing strategy (including rationale)
QA

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dengziming
Copy link
Member Author

We can safely remove this class since we have removed kafka.security.auth.Authorizer in #10450 , ping @ijuma to have a look

ijuma
ijuma approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the build passes.

@cmccabe cmccabe merged commit c9c03dd into apache:trunk Mar 21, 2022
@dengziming dengziming deleted the minor-remove-kafka-exc branch October 8, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dengziming @ijuma @cmccabe